Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchedMesh: Remove unneeded & redundant matrices array #27130

Merged
merged 17 commits into from
Nov 6, 2023

Conversation

gkjohnson
Copy link
Collaborator

Related issue: #27111, #22376

Description

Previously to toggle visibility the matrices were set to a 0 scale to "hide" them which meant that the matrices needed to be double-stored in an array and a texture so no data was lost. Now that visibility is handled by the multi-draw extension we can remove the extra _matrices storage.

@gkjohnson gkjohnson added this to the r159 milestone Nov 6, 2023
@gkjohnson gkjohnson requested a review from Mugen87 November 6, 2023 10:21
Comment on lines -523 to +512
return matrix;
return null;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no data for the matrix then we just return null here to indicate there's no relevant value.

@gkjohnson gkjohnson merged commit 5f4f0b2 into mrdoob:dev Nov 6, 2023
18 checks passed
@gkjohnson gkjohnson deleted the remove-unneeded-arrays branch November 6, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants