Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewportNode revision #27096

Merged
merged 5 commits into from
Nov 1, 2023
Merged

ViewportNode revision #27096

merged 5 commits into from
Nov 1, 2023

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Nov 1, 2023

Related issue: #27083 (comment)

Description

Fixed viewportResolution compilation error and revision to improve WebGLBackend compatibility.

@sunag sunag added this to the r159 milestone Nov 1, 2023
@sunag sunag marked this pull request as ready for review November 1, 2023 03:37
@sunag sunag merged commit 79cc152 into mrdoob:dev Nov 1, 2023
18 checks passed
@sunag sunag deleted the dev-fix-viewportNode branch November 1, 2023 06:40
@@ -102,9 +99,9 @@ class ViewportNode extends Node {

// follow webgpu standards

const resolution = viewportResolution.build( builder );
const resolution = builder.getNodeProperties( viewportResolution ).outputNode.build( builder );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does viewportResolution.build( builder ) not work? (Possibly it could be fixed with one of the changes from my PR -- introducing Node.fullBuild(), which runs all builds from all build stages on a node)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ping @sunag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants