Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchedMesh: Add thrown errors #27060

Merged
merged 9 commits into from
Oct 26, 2023
Merged

BatchedMesh: Add thrown errors #27060

merged 9 commits into from
Oct 26, 2023

Conversation

gkjohnson
Copy link
Collaborator

@gkjohnson gkjohnson commented Oct 26, 2023

Related issue: #25059, #22376

Description

  • Add thrown errors for failure cases
  • Ensure the added geometry has at least all the same attributes
  • Add pure, glsl comment annotation

cc @takahirox

@gkjohnson gkjohnson added this to the r158 milestone Oct 26, 2023
@@ -104,7 +104,7 @@
geometries = [
new THREE.ConeGeometry( 1.0, 2.0 ),
new THREE.BoxGeometry( 2.0, 2.0, 2.0 ),
new THREE.SphereGeometry( 1.0 ),
new THREE.SphereGeometry( 1.0, 16, 8 ),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the errors I found that we were overwriting the end of BatchedMesh geometry index in the example - so I simplified the sphere so it has fewer vertices to avoid that case.

@Mugen87 Mugen87 merged commit 2337906 into mrdoob:dev Oct 26, 2023
17 of 18 checks passed
@gkjohnson gkjohnson deleted the add-errors branch October 30, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants