Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BatchedMesh: Clean up. #27054

Merged
merged 4 commits into from
Oct 25, 2023
Merged

BatchedMesh: Clean up. #27054

merged 4 commits into from
Oct 25, 2023

Conversation

gkjohnson
Copy link
Collaborator

@gkjohnson gkjohnson commented Oct 25, 2023 •
edited
Loading

Related issue: #25059, #22376

Description

  • Adjust grammar of some of the member names: "alives" to "active", "visibles" to "visible"
  • Remove unnecessary redundant storage of matrix texture information
  • Change attribute id name to something more unique - id -> _batch_id_
    • For reference the 3d tiles' (now legacy) b3dm format uses the _batchid identifier

cc @takahirox

@Mugen87 Mugen87 added this to the r158 milestone Oct 25, 2023
@Mugen87 Mugen87 merged commit c5b97d6 into mrdoob:dev Oct 25, 2023
18 checks passed
@Mugen87 Mugen87 changed the title BatchMesh: BatchMesh: Clean up. Oct 25, 2023
@Mugen87 Mugen87 changed the title BatchMesh: Clean up. BatchedMesh: Clean up. Oct 25, 2023
@gkjohnson gkjohnson deleted the batch-members-cleanup branch October 25, 2023 10:12
This was referenced Oct 27, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r158
Development

Successfully merging this pull request may close these issues.
2 participants
@gkjohnson @Mugen87