Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BatchedMesh Example: fix floating point error in rotation #27046

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

gkjohnson
Copy link
Collaborator

Related issue: #25059

Description

It seems that the previous approach of decomposing the rotation from a matrix was resulting in lost rotation information due to floating point error or something - either way all the geometry was starting to rotate in the same direction. This PR avoids decomposition to address this.

Before

Cubes used everywhere to make the issue more clear

batched-error.mp4

After

Notice the shapes rotating in different directions

batch-example-fix.mp4

cc @takahirox

@gkjohnson gkjohnson added this to the r158 milestone Oct 24, 2023
@Mugen87 Mugen87 merged commit 7905b2b into mrdoob:dev Oct 25, 2023
18 checks passed
@gkjohnson gkjohnson deleted the fix-batch-example-floating-errors branch October 25, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants