Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capsule: Move and rename lineToLineClosestPoints function to Octree util #27044

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

gkjohnson
Copy link
Collaborator

Fix #26923

Description

Found some time to move the function. Moves the function from capsule class (where it confusingly didn't refer to the current capsule) to octree class file as util.

@gkjohnson gkjohnson added this to the r158 milestone Oct 24, 2023
@gkjohnson gkjohnson requested a review from Mugen87 October 24, 2023 12:06
@Mugen87 Mugen87 merged commit 8fea5d2 into mrdoob:dev Oct 24, 2023
17 checks passed
@gkjohnson gkjohnson deleted the octree-line-seg-points-func branch October 24, 2023 12:12
CITIZENDOT pushed a commit to CITIZENDOT/three.js that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capsule: "lineLineMinimumPoints" function returns global temp variables, does not use Capsule fields
2 participants