Editor: Remove Fix Color Maps script.
#27033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CITIZENDOT
pushed a commit
to CITIZENDOT/three.js
that referenced
this pull request
Oct 25, 2023
* Editor: Remove `Fix Color Maps` script. * Editor: Clean up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #15903, #16148
Description
The
Fix Color Mapsmenu item in the editor triggers a script that set thecolorSpaceproperty of all color textures in the scene toSRGBColorSpace. The script was intended to ensure "old" scenes use a more correct color space configuration.Now that all loaders properly set color spaces and the editors UI also set the
colorSpaceproperty when a map is added, I think it's safe to remove the script from the editor. If someone relies on it, devs can use https://rawcdn.githack.com/mrdoob/three.js/r157/editor/index.html.