Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point-light shadows example github link is broken #27015

Merged

Conversation

mkkellogg
Copy link
Contributor

A very non-urgent fix :)

Currently the point-light shadow example page (https://threejs.org/examples/?q=shadow#webgl_shadowmap_pointlight) has a github link that when followed gives the following error in the console:

Refused to frame 'https://github.com/' because an ancestor violates the following Content Security Policy directive: "frame-ancestors 'none'".

Adding the target="_blank" and rel="noopener" attributes to the link fixes it.

@Mugen87 Mugen87 added this to the r158 milestone Oct 20, 2023
@Mugen87 Mugen87 merged commit 1c565de into mrdoob:dev Oct 20, 2023
17 checks passed
@mkkellogg mkkellogg deleted the fix_pointlight_shadow_example_github_link branch February 17, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants