Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shaders: add shader name #27014

Merged
merged 3 commits into from
Oct 20, 2023
Merged

Shaders: add shader name #27014

merged 3 commits into from
Oct 20, 2023

Conversation

WestLangley
Copy link
Collaborator

@WestLangley WestLangley commented Oct 20, 2023 •
edited
Loading

Continuing the pattern from previous PRs, this PR adds the shader name property where appropriate.

The shader name is useful when examining renderer.info, and it appears in the shader source when WebGLRenderer is used.

@WestLangley WestLangley added this to the r158 milestone Oct 20, 2023
@Mugen87 Mugen87 merged commit 7f351a0 into mrdoob:dev Oct 20, 2023
18 checks passed
@WestLangley WestLangley deleted the dev-shader_name branch October 20, 2023 15:09
This was referenced Oct 27, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r158
Development

Successfully merging this pull request may close these issues.
2 participants
@WestLangley @Mugen87