Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMREMGenerator: Correctly restore render target. #27013

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 19, 2023

Fixed #27011.

Description

This PR ensures PMREMGenerator correctly restores the render target setup after rendering.

@Mugen87 Mugen87 added this to the r158 milestone Oct 19, 2023
@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
652.3 kB (161.6 kB) 652.4 kB (161.7 kB) +174 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
444.9 kB (107.6 kB) 445 kB (107.7 kB) +174 B

@Mugen87 Mugen87 merged commit 8428bb6 into mrdoob:dev Oct 19, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Second cube camera as envmap produces strange artifacts
1 participant