Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: implement readRenderTargetPixelsAsync() for WebGL backend #27006

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

aardgoose
Copy link
Contributor

Using https://developer.mozilla.org/en-US/docs/Web/API/WebGL_API/WebGL_best_practices for non blocking read back.

Currently we don't cache framebuffer objects via renderTarget, so can't use existing objects, if beginRender() was passed renderTarget as well as renderContext we could implement this for the WebGL path. Is that a reasonable idea?

@sunag

@sunag sunag added this to the r158 milestone Oct 19, 2023
@sunag
Copy link
Collaborator

sunag commented Oct 19, 2023

Currently we don't cache framebuffer objects via renderTarget, so can't use existing objects, if beginRender() was passed renderTarget as well as renderContext we could implement this for the WebGL path. Is that a reasonable idea?

Sorry, I didn't understand exactly what that would be.

@mrdoob mrdoob modified the milestones: r158, r159 Oct 27, 2023
@sunag
Copy link
Collaborator

sunag commented Nov 23, 2023

Hi @aardgoose, the PR is still a draft, is there anything pending or can we merge it?

@aardgoose aardgoose marked this pull request as ready for review November 24, 2023 11:18
@aardgoose
Copy link
Contributor Author

It should be OK.

@mrdoob mrdoob merged commit 3b86f57 into mrdoob:dev Nov 28, 2023
18 checks passed
@aardgoose aardgoose deleted the ctb branch December 16, 2023 12:07
AdaRoseCannon pushed a commit to AdaRoseCannon/three.js that referenced this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants