SkinnedMesh: Introduce constants for bindMode
.
#26985
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:-
Description
Compared to other classes,
SkinnedMesh.bindMode
uses plain strings instead of constants which is inconsistent. The PR addsTHREE.AttachedBindMode
andTHREE.DetachedBindMode
and also clarifies the documentation what both bind modes actually do.The PR does not break code since the values of the constants are equal to the existing strings.