Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes: Update PropertyNode exports #26975

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Nodes: Update PropertyNode exports #26975

merged 1 commit into from
Oct 19, 2023

Conversation

LeviPesin
Copy link
Contributor

Related issue: #26930 (comment)

Description

Add missing PropertyNode exports.

@sunag Also, maybe we should move those exports (i.e. output, diffuseColor, roughness, metalness, clearcoat, clearcoatRoughness, sheen, sheenRoughness, iridescence, iridescenceIOR, iridescenceThickness, specularColor, shininess, dashSize, gapSize, pointWidth) to some file in accessors/ directory? It doesn't feel correct to export them from core/...

@sunag
Copy link
Collaborator

sunag commented Oct 16, 2023

to some file in accessors/ directory? It doesn't feel correct to export them from core/...

I agree!

@sunag sunag added this to the r158 milestone Oct 16, 2023
@sunag sunag merged commit 5377a02 into mrdoob:dev Oct 19, 2023
18 checks passed
@LeviPesin LeviPesin deleted the patch-8 branch October 20, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants