Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Environment Nodes Hash #26942

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Oct 11, 2023

Related issue: Fixes #26917

Description

After #26729, updates to "environment" Nodes such as Scene Lights, Tone Mapping and Fog would only be updated after the user defines material.needsUpdate=true, this PR check it automaticaly.

A cache was added to calculate the hash, which gives a significant performance gain for more than 1k meshes, for example.

@sunag sunag added this to the r158 milestone Oct 11, 2023
@sunag sunag marked this pull request as ready for review October 11, 2023 05:59
@sunag sunag merged commit cb42582 into mrdoob:dev Oct 11, 2023
18 checks passed
@sunag sunag deleted the dev-fix-env-nodes branch October 11, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With WebGPU, light don't work
1 participant