Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes: Fixes and clean up #26931

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Nodes: Fixes and clean up #26931

merged 1 commit into from
Oct 10, 2023

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Oct 10, 2023

Related issue: #26911, #26795

Description

Some fixes and revisions to the previous PR's mentioned above.

@sunag sunag added this to the r158 milestone Oct 10, 2023
@sunag sunag marked this pull request as ready for review October 10, 2023 04:48
@sunag sunag merged commit 9116475 into mrdoob:dev Oct 10, 2023
17 checks passed
@sunag sunag deleted the dev-node-revs branch October 10, 2023 04:49

if ( output !== 'void' ) {

return positionLocal.build( builder, output );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we just return positionLocal in setup? Or would it not work in this way?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will not work if the output is void, but this treatment can certainly be done automatically soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants