Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IFFParser: Convert to ES6 classes. #26929

Merged
merged 1 commit into from
Oct 10, 2023
Merged

IFFParser: Convert to ES6 classes. #26929

merged 1 commit into from
Oct 10, 2023

Conversation

CodyJasonBennett
Copy link
Contributor

Related issue: #19986

Description

Converts IFFParser used by LWOLoader to ES6 classes for tree-shaking as part of #26912.

gkjohnson
gkjohnson approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@gkjohnson gkjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://raw.githack.com/CodyJasonBennett/three.js/iffparser-es6/examples/webgl_loader_lwo.html

@Mugen87 Mugen87 added this to the r158 milestone Oct 10, 2023
@Mugen87 Mugen87 merged commit 8c76040 into mrdoob:dev Oct 10, 2023
17 checks passed
@CodyJasonBennett CodyJasonBennett deleted the iffparser-es6 branch October 10, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkjohnson gkjohnson gkjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r158
Development

Successfully merging this pull request may close these issues.
3 participants
@CodyJasonBennett @gkjohnson @Mugen87