Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMAAPass: Swap buffers after rendering. #26928

Merged
merged 2 commits into from
Oct 9, 2023
Merged

SMAAPass: Swap buffers after rendering. #26928

merged 2 commits into from
Oct 9, 2023

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Oct 9, 2023

Related issue: -

Description

SMAAPass previously set needsSwap to false. This comes from a time when color space conversion in context of post processing wasn't supported yet. To make OutputPass operate on the correct data, SMAAPass must swap buffers like all other passes. Otherwise the anti-aliasing of SMAAPass isn't honored.

@Mugen87 Mugen87 added this to the r158 milestone Oct 9, 2023
@Mugen87 Mugen87 merged commit 0590d5f into mrdoob:dev Oct 9, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant