Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test-circular-deps script #26926

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

marcofugaro
Copy link
Contributor

Related issue: #26161 (comment)

Description

Added a test and a CI job to check if there's any circular dependencies in the nodes.

It uses the dpdm library.
image

Useful for @sunag and @LeviPesin.

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
649.1 kB (160.9 kB) 649.1 kB (160.9 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
442.4 kB (107.1 kB) 442.4 kB (107.1 kB) +0 B

@sunag sunag added this to the r158 milestone Oct 10, 2023
@mrdoob mrdoob merged commit 128b9b5 into mrdoob:dev Oct 11, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants