Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Use <math> for equations in webgl_multiple_elements_text.html #26896

Merged
merged 5 commits into from
Oct 4, 2023

Conversation

ycw
Copy link
Contributor

@ycw ycw commented Oct 3, 2023

@Mugen87 Mugen87 added this to the r158 milestone Oct 3, 2023
@WestLangley
Copy link
Collaborator

The fractions are displaying incorrectly. Should be

Screenshot 2023-10-03 at 11 55 46 AM

There are multiple instances of a similar error.

@ycw
Copy link
Contributor Author

ycw commented Oct 3, 2023

would you mind provide the incorrect shots for comparison

@WestLangley
Copy link
Collaborator

Currently, with this PR

Screenshot 2023-10-03 at 3 14 03 PM

@WestLangley
Copy link
Collaborator

Hmm... Your edit to main.css fixed the issue for me in Chrome and Firefox, but not in Safari. MacOS Sonoma 14.0.

@WestLangley
Copy link
Collaborator

But what you are doing now is a hack, no?

Granted, it is not a central issue, so I am not going to press it... but the fractions are still too close together in Safari, IMHO.

@ycw
Copy link
Contributor Author

ycw commented Oct 4, 2023

The spec requires UA to do this:

... To avoid visual confusion between the fraction bar and another adjacent items (e.g. minus sign or another fraction's bar), a default 1-pixel space is added around the element. The user agent stylesheet must contain the following rules: ...

but safari misbehaved, so a patch is needed

8a78521: mspace is semantically correct, and supported since safari7, but this option will cause visually diff btwn safari and non-safari (space is much wider in non-safari)

Lets try another option

[sha]: adds a dot operator between mfracs. The dot in safari should behave like the minus in #26896 (comment) which has proper space added around; U+22C5 is semantically correct, but the equations now looks more 'verbose' (a dot is added between the const and derivatives)

@WestLangley
Copy link
Collaborator

I think adding the dot is a good solution.

@ycw ycw requested a review from Mugen87 October 4, 2023 00:53
@Mugen87 Mugen87 merged commit a2050bc into mrdoob:dev Oct 4, 2023
17 checks passed
@ycw ycw deleted the wgl_mult_els_text branch May 2, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants