Nodes: Define stack.assign() as default.
#26881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeviPesin
reviewed
Oct 2, 2023
| @@ -48,7 +48,7 @@ const shaderNodeHandler = { | |||
|
|
|||
| const nodeElement = NodeElements.get( prop.slice( 0, prop.length - 'Assign'.length ) ); | |||
|
|
|||
| return ( ...params ) => nodeObj.assign( nodeElement( nodeObj, ...params ) ); | |||
| return node.isStackNode ? ( ...params ) => nodeObj.assign( params[ 0 ], nodeElement( ...params ) ) : ( ...params ) => nodeObj.assign( nodeElement( nodeObj, ...params ) ); | |||
There was a problem hiding this comment.
Could we please also do this in the if ( NodeElements.has( prop ) ) clause? Then we can remove StackNode.loop and StackNode.assign.
LeviPesin
reviewed
Oct 2, 2023
| @@ -68,6 +69,23 @@ class StackNode extends Node { | |||
|
|
|||
| assign( targetNode, sourceValue ) { | |||
|
|
|||
| sourceValue = nodeObject( sourceValue ); | |||
There was a problem hiding this comment.
I don't think we need all of this, we can just remove this function and rely on ShaderNode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #26820, #26821 (comment)
Description
Using
StackNode.assign()instead ofVarNode.assign()makes the control flow less confusing and more optimized,StackNodecan work as the lines of code are when creating the Shader, thus being able to add statements and conditions in correct sequences, for example.A revision was made to the Lighting Model in favor of the standard.