Cleanup examples #26869
Merged
Cleanup examples #26869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Methuselah96
commented
Sep 29, 2023
| console.log( 'model ' + Math.round( percentComplete, 2 ) + '% downloaded' ); | ||
| console.log( 'model ' + percentComplete.toFixed( 2 ) + '% downloaded' ); |
There was a problem hiding this comment.
Math.round doesn't take a second parameter. toFixed accomplishes the desired behavior.
Methuselah96
commented
Sep 29, 2023
| gui.add( playbackConfig, 'wireframe', false ).onChange( function () { | ||
| gui.add( playbackConfig, 'wireframe' ).onChange( function () { |
There was a problem hiding this comment.
gui.add doesn't do anything with the third parameter if the property value is a boolean.
Methuselah96
commented
Sep 29, 2023
| @@ -210,7 +210,7 @@ | |||
| start.multiplyScalar( 75 ); | |||
| end.multiplyScalar( 75 ); | |||
|
|
|||
| const object = new THREE.Mesh( boxGeometry, new THREE.MeshPhongMaterial( 0xffffff ) ); | |||
| const object = new THREE.Mesh( boxGeometry, new THREE.MeshPhongMaterial( { color: 0xffffff } ) ); | |||
There was a problem hiding this comment.
The MeshPhongMaterial takes an object of parameters. 0xffffff matches the default color, so alternatively it could be removed altogether.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #XXXX
Description
Explanations below.