Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGLProgram: Fragment shader also needs to define precision for sampler2DArray. #26853

Merged
merged 1 commit into from
Sep 29, 2023
Merged

WebGLProgram: Fragment shader also needs to define precision for sampler2DArray. #26853

merged 1 commit into from
Sep 29, 2023

Conversation

kasparsj
Copy link
Contributor

trying to get ShaderMaterial work with sampler2DArray uniforms

@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
649 kB (160.9 kB) 649 kB (160.9 kB) +36 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
442.3 kB (107 kB) 442.4 kB (107 kB) +36 B

Mugen87
Mugen87 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@Mugen87 Mugen87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. The engine uses sampler2DArray only for morph targets right now and that happens in the vertex shader.

@Mugen87 Mugen87 added this to the r157 milestone Sep 26, 2023
@Mugen87 Mugen87 changed the title fragment shader also needs to define precision for sampler2DArray WebGLProgram: Fragment shader also needs to define precision for sampler2DArray. Sep 26, 2023
@mrdoob mrdoob modified the milestones: r157, r158 Sep 28, 2023
@Mugen87 Mugen87 merged commit cc98a1f into mrdoob:dev Sep 29, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r158
Development

Successfully merging this pull request may close these issues.
3 participants
@kasparsj @Mugen87 @mrdoob