Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDrawLoader: Use WeakMap instead of userData for indexing materials. #26700

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Sep 5, 2023

Fixed #26279.

Description

LDrawLoader does not use Material.userData anymore to store references to other materials. This makes sure assets loaded with LDrawLoader do not throw runtime errors during serialization (e.g. when the editor auto-saves the scene).

@Mugen87 Mugen87 added this to the r157 milestone Sep 5, 2023
@gkjohnson
Copy link
Collaborator

@Mugen87 Mugen87 merged commit e6b9d24 into mrdoob:dev Sep 5, 2023
@Methuselah96 Methuselah96 mentioned this pull request Sep 13, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor - broken LDRAW support and missing PDB support
2 participants