Nodes: export viewport and minor fixes #26698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeviPesin
reviewed
Sep 5, 2023
|
Can you please also add BumpMapNode, HashNode, and Schlick_to_F0? They were added in previous PRs but weren't, I think, added to the exports. |
mrdoob
reviewed
Sep 14, 2023
| super( scope ); | ||
|
|
||
| } | ||
|
|
||
| construct( builder ) { |
There was a problem hiding this comment.
Hmm... Would it make sense to rename construct() to build()?
There was a problem hiding this comment.
I think build is already used for the last step -- turning the node into a shader code fragment. The construct name for the node constructing step seems nice 👍
There was a problem hiding this comment.
Ah, maybe setup() then? Or configure()?
Just trying to differentiate it from constructor()...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.