KTX2Loader: Fix regression with 3D textures. #26679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
reviewed
Aug 31, 2023
|
Yes, here's a 3D texture (size 33 , FloatType) of a LUT compressed with |
|
@donmccurdy Should I merge this and release |
donmccurdy
approved these changes
Sep 1, 2023
|
@mrdoob I believe use of KTX2 with DataTexture and Data3DTexture is rare compared to storing compressed textures, so this is not hugely urgent, but if you don't mind making a r0.156.1 patch, yes that would be ideal! |
|
In any event, the PR can be merged 😇 . |
Mugen87
changed the title
|
Given #26691 ... perhaps a patch release would be best after all – thank you! 😇 |
|
Indeed!^^ |
|
Will do! |
mrdoob
pushed a commit
that referenced
this pull request
Sep 5, 2023
* KTX2Loader: fix data textures * remove redundant mipmap assignment * use first mipmap unconditionally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the latest changes in KTX2Loader of
r156, data 3D textures stopped working. This PR fixes them.