TSL: textureStore() and example #26648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
WestLangley
reviewed
Aug 26, 2023
Comment on lines
+60
to
+61
| storageTexture.magFilter = THREE.LinearFilter; | ||
| storageTexture.minFilter = THREE.NearestFilter; |
There was a problem hiding this comment.
@sunag Is there a reason these are different?
There was a problem hiding this comment.
Nothing special, I'll change it so as not to confuse.
This was referenced Aug 26, 2023
|
Improved the example to make it more visually appealing in d6c8dd0 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Close #26600
Description
Added support for
textureStore()and added an example of GPU Compute using WGSL. At the moment I can't add a very extensive support fortextureStore()due to the other open tasks ofWebGPURenderer, but this could certainly be done if not for me by other collaborators, this PR opens a way for this implementation.