Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Clean up. #26603

Merged
merged 1 commit into from
Aug 19, 2023
Merged

src: Clean up. #26603

merged 1 commit into from
Aug 19, 2023

Conversation

linbingquan
Copy link
Contributor

Related issue: #XXXX

Description

Make internal variable with _

@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
646.2 kB (160.3 kB) 646.2 kB (160.3 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
439.1 kB (106.4 kB) 439.1 kB (106.4 kB) +0 B

@Mugen87 Mugen87 added this to the r156 milestone Aug 19, 2023
@Mugen87 Mugen87 merged commit 67d574b into mrdoob:dev Aug 19, 2023
@linbingquan linbingquan deleted the dev-id branch August 19, 2023 12:18
@linbingquan linbingquan mentioned this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants