Audio: Prevent null source error in disconnect().

[takahirox]

Problem

Audio.disconnect() expects Audio.source is non-null and calls Audio.source.disconnect(). But Audio.source is initialized as null in the constructor and later it is set in .play() or .set*() methods.

So if Audio.disconnect() is called before starting to play or setting source, it can cause an error when attemping to call Audio.source.disconnect()

Solution

In Audio.disconnect() add a guard that checks audio is already connected.

Alternative solutions

1. If we think it should be managed on user end whether .disconnect() can be called it would be good to add an API to know whether it's connected. Currently users can check with Audio.source !== null but it may not be intuitive. We may add a getter for ._connected.

// in Audio
get connected() {
  return this._connected;
}

// User code
if (audio.connected) {
  audio.disconnect();
}

2. Add a description in the documents that calling Audio.disconnect() before starting to play or setting source can cause an error.

[github-actions]

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev	Filesize PR	Diff
646.2 kB (160.3 kB)	646.2 kB (160.3 kB)	+26 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev	Filesize PR	Diff
439.1 kB (106.4 kB)	439.1 kB (106.4 kB)	+0 B