Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSAOPass: Prevent color shift of background. #26594

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Aug 17, 2023

Related issue: -

Description

This PR fixes a long-standing issue with SSAOPass. The effect does not have any influence on the background color anymore. Meaning enabling SSAO only adds the ambient occlusion and doesn't further alter the image.

The PR also removes an unused uniform from SSAOShader.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Aug 17, 2023

@Mugen87 Mugen87 added this to the r156 milestone Aug 17, 2023
@mrdoob mrdoob merged commit 621cd32 into mrdoob:dev Aug 17, 2023
@mrdoob
Copy link
Owner

mrdoob commented Aug 17, 2023

Yay!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants