Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: Fix flickering in decals demo. #26593

Merged
merged 1 commit into from
Aug 17, 2023
Merged

Examples: Fix flickering in decals demo. #26593

merged 1 commit into from
Aug 17, 2023

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Aug 16, 2023

Related issue: https://discourse.threejs.org/t/three-js-edit-planegeometry-look-realistic/55009/4

Description

It was noticed in the forum that the decal demo shows flickering with overlapping decals when the camera is moved around the asset. After investigating the issue I can confirm that #25913 changed the behavior of the example.

In order to provide a stable render order, the demo defines now a value for Object3D.renderOrder for all decals. I'm open for other suggestions that fix the issue equally good.

@Mugen87 Mugen87 requested a review from donmccurdy August 16, 2023 18:31
@mrdoob mrdoob added this to the r156 milestone Aug 17, 2023
@mrdoob mrdoob merged commit f18ebe1 into mrdoob:dev Aug 17, 2023
@donmccurdy
Copy link
Collaborator

This looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants