Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Fix DataTexture - FloatType #26585

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Aug 15, 2023

Related issue: Fixes #26576

Description

WebGPU does not support texture filtering/sampling in 32bit format except for the "float32-filterable" extension which seems to be unavailable at the moment. This PR disables sampling for DataTexture that uses FloatType.

@sunag sunag added this to the r156 milestone Aug 15, 2023
@sunag sunag merged commit c849b5d into mrdoob:dev Aug 15, 2023
@Spiri0
Copy link
Contributor

Spiri0 commented Aug 15, 2023

I also read the warning about the unfilterable float, but didn't know how to classify it and what it means in detail because i don't want to filter anything. If I understand you correctly, there will be an extension in the WebGPURenderer in r156 that will solve the problem?
Please forgive my question, I'm only an user so far and have never had anything to do with the development process of 3js.
I tried my best to create a clear example to save work.
Perhaps it would then be suitable for an extension of the 3js example library, since it contains several node elements in connection with wgsl, but that is another topic.

@sunag
Copy link
Collaborator Author

sunag commented Aug 15, 2023

there will be an extension in the WebGPURenderer in r156 that will solve the problem?

Probably not in r156, it depends on when we have this extension created by W3C WebGPU to add and test this feature. This is already flagged in the documentation so it must be in development.

Thanks for the example, even if you weren't using it in your WGSL code, the settings were loaded by the layout by default was to give proper sampler support if you needed it, but for DataTexture - FloatType, as we see this is incompatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wgsl does not understand "FloatType" in DataTextures
2 participants