WebGPURenderer: Performance revision #26556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeviPesin
reviewed
Sep 4, 2023
| @@ -16,7 +16,7 @@ class Object3DNode extends Node { | |||
|
|
|||
| this.updateType = NodeUpdateType.OBJECT; | |||
|
|
|||
| this._uniformNode = uniform( null ); | |||
| this._uniformNode = new UniformNode( null ); | |||
There was a problem hiding this comment.
What is the difference here?
There was a problem hiding this comment.
It was part of what I described about avoiding NodeObject (Use Non-NodeObject for uniforms.), in general Nodes that need to be updated for every frame.
There was a problem hiding this comment.
But what is the benefit then? UniformNode is still a node.
There was a problem hiding this comment.
But what is the benefit then?
Better performance.
There was a problem hiding this comment.
Is there a significant difference in performance between a node and a node wrapped in nodeObject?
LeviPesin
reviewed
Sep 4, 2023
| @@ -37,6 +37,10 @@ const shaderNodeHandler = { | |||
|
|
|||
| return ( ...params ) => nodeElement( nodeObj, ...params ); | |||
|
|
|||
| } else if ( prop === 'self' ) { | |||
|
|
|||
| return node; | |||
There was a problem hiding this comment.
Maybe it should be something like node.self || node?
45 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #26469
Description
Cache NodeBuilder
Caching NodeBuilder reduces significantly compilation time when there are many objects in the scene.
Use Non-NodeObject for uniforms.
The function added
Node.getSelf()gets a Non-NodeObject, this helps performance on uniforms because it doesn't need to pass TSL processing in the Proxy class.Cache MaterialNode uniforms
Caching
MaterialNodeuniforms andNodeUpdateType.RENDERusage reduces redundant update cycles.--
Some other minor improvements have been made.
This work continues in other PR.