-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MMDLoader: Apply color management to textures. #26554
MMDLoader: Apply color management to textures. #26554
Conversation
donmccurdy
commented
Aug 8, 2023
- Fixes MMDLoader Colorization Issue #26553
- Related Roadmap for supporting wide-gamut color workflows #26479
- Related Examples: Clean up. #26135
- Related Examples: Updates for color management (pt3) #25889
before | after |
---|---|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, yes we are missing color space assignment on color textures in MMD loader.
I tested locally with a PMX file. Using SRGB color space looks fine. Reference: https://www.nicovideo.jp/watch/sm18003162
|
@jasondalycan the renderings above appear similar enough to me that they may be caused only by lighting and not color management. Some adjustments to lighting are to be expected, given changes in the past few releases. Adjustment to If there does seem to be a remaining color management issue, I think we would need an example (model) to investigate it. |
Ok thanks I'll work with adjusting lighting settings and report back if any additional findings. cheers |
see #28336 (comment) |