Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPURenderer: Add data-engine="three.js ${REVISION}" to <canvas>. #26544

Merged
merged 1 commit into from
Aug 8, 2023
Merged

WebGPURenderer: Add data-engine="three.js ${REVISION}" to <canvas>. #26544

merged 1 commit into from
Aug 8, 2023

Conversation

linbingquan
Copy link
Contributor

Related issue: #XXXX

Description

As the title.

@linbingquan linbingquan force-pushed the dev-webgpu-revision branch from 13169cb to 0efd399 Compare August 8, 2023 10:15
@Mugen87 Mugen87 added this to the r156 milestone Aug 8, 2023
@Mugen87 Mugen87 merged commit 1516e3f into mrdoob:dev Aug 8, 2023
@linbingquan linbingquan deleted the dev-webgpu-revision branch August 8, 2023 11:12
@mrdoob
Copy link
Owner

mrdoob commented Aug 10, 2023

Shouldn't this be added outside the null check?

@Mugen87
Copy link
Collaborator

Mugen87 commented Aug 10, 2023

When I understand the code correctly, getDomElement() might be called multiple times. So the null check is for the first invocation when no domElement has been created so far. At this point, the data-engine attribute is defined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r156
Development

Successfully merging this pull request may close these issues.
3 participants
@linbingquan @mrdoob @Mugen87