Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeshPhysicalMaterial: Adjust docs for new effects #26543

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

mjurczyk
Copy link
Contributor

@mjurczyk mjurczyk commented Aug 6, 2023

Description

  • Fix specularIntensity docs saying default is 0.0 (while it's actually 1.0 source 🥲)
  • Add missing iridescence props to the docs, incl. explanation of what iridescence actually is, and how iridescenceThicknessMap min-max works.
  • There was some inconsistency between using R / G channel and red / green channel naming, renamed occurrences to just full color names for simplicity.

MeshPhysicalMaterial: Add missing iridescence docs
@Mugen87 Mugen87 added this to the r156 milestone Aug 8, 2023
@Mugen87 Mugen87 merged commit 6a91291 into mrdoob:dev Aug 8, 2023
@mjurczyk mjurczyk deleted the mjurczyk-dev branch August 8, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants