Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes: add ViewportNode.VIEWPORT #26540

Merged
merged 2 commits into from
Aug 8, 2023
Merged

Nodes: add ViewportNode.VIEWPORT #26540

merged 2 commits into from
Aug 8, 2023

Conversation

aardgoose
Copy link
Contributor

For some use cases access to the current renderer viewport rather than the drawing buffer dimensions is required.

@@ -107,6 +120,7 @@ export default ViewportNode;

export const viewportCoordinate = nodeImmutable( ViewportNode, ViewportNode.COORDINATE );
export const viewportResolution = nodeImmutable( ViewportNode, ViewportNode.RESOLUTION );
export const viewportViewport = nodeImmutable( ViewportNode, ViewportNode.VIEWPORT );
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just viewport sounds better.

@sunag sunag added this to the r156 milestone Aug 6, 2023
@sunag sunag merged commit 10275da into mrdoob:dev Aug 8, 2023
@LeviPesin
Copy link
Contributor

Shouldn't we also update exports in Nodes.js?

@aardgoose
Copy link
Contributor Author

I'll add that with some of your other points.

@aardgoose aardgoose deleted the viewport branch September 5, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants