Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeBuilder: Fix construct() node data #26533

Merged
merged 3 commits into from
Aug 4, 2023
Merged

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Aug 3, 2023

Related issue: #26528

Description

Node.construct() was missing the return Node when it was constructed and reused in different shader stages.

@sunag sunag added this to the r156 milestone Aug 3, 2023
@sunag sunag merged commit e5426b0 into mrdoob:dev Aug 4, 2023
@sunag sunag deleted the dev-fix-node-properties branch August 4, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant