Loaders: Bubble parsing errors in remaining data texture loaders. #26499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
LeviPesin
reviewed
Sep 2, 2023
| @@ -2047,8 +2047,8 @@ class EXRLoader extends DataTextureLoader { | |||
|
|
|||
| if ( ( spec & ~ 0x04 ) != 0 ) { // unsupported tiled, deep-image, multi-part | |||
|
|
|||
| console.error( 'EXRHeader:', EXRHeader ); | |||
| throw new Error( 'THREE.EXRLoader: provided file is currently unsupported.' ); | |||
| console.error( 'THREE.EXRHeader:', EXRHeader ); | |||
There was a problem hiding this comment.
EXRHeader isn't a Three's class, why is it prefixed with THREE.?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #26457.
Description
This PR updates the remaining data texture loaders so they properly throw parsing errors.
EXRLoaderalready throws errors so there are just some formatting updates.LogLuvLoaderandRGBELoaderrequired some updates.TIFFLoaderandRGBMLoaderuse external modules for parsing which I did not want to monkey patch.