WebGPURenderer: Iridescence #26489
Merged
WebGPURenderer: Iridescence #26489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeviPesin
reviewed
Sep 1, 2023
| // Force iridescenceIOR -> outsideIOR when thinFilmThickness -> 0.0 | ||
| const iridescenceIOR = mix( outsideIOR, eta2, smoothstep( 0.0, 0.03, thinFilmThickness ) ); | ||
| // Evaluate the cosTheta on the base layer (Snell law) | ||
| const sinTheta2Sq = outsideIOR.div( iridescenceIOR ).pow2().mul( float( 1 ).sub( cosTheta1.pow2() ) ); |
There was a problem hiding this comment.
I think we can use oneMinus here and in similar places below.
LeviPesin
reviewed
Sep 1, 2023
| const Ess = fab.x.add( fab.y ); | ||
| const Ems = Ess.oneMinus(); | ||
|
|
||
| const Favg = specularColor.add( specularColor.oneMinus().mul( 0.047619 ) ); // 1/21 |
There was a problem hiding this comment.
Can't we just write this constant as 1/21 then? It will be converted into its decimal form in any case while building.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #26486
Description
Added
iridescencesupport forPhysical Lighting Model.webgpu_loader_gltf_iridescenceexampleFixes