GLTFLoader: Fix loadAnimation() refactor.
#26477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hybridherbst
changed the title
hybridherbst
changed the title
Mugen87
approved these changes
Jul 22, 2023
Mugen87
changed the title
loadAnimation() refactor.
hybridherbst
added a commit
to needle-tools/three.js
that referenced
this pull request
Jul 23, 2023
* GLTFLoader: some code to be accessible from extensions on parser * move targetNames code earlier * bring outputAccessor.itemSize switch back * linting # Conflicts: # examples/jsm/loaders/GLTFLoader.js
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
bug introduced in
that caused cubic interpolators in glTF to break.
Description
One mistake during the earlier refactor, my bad.
cc @Mugen87