Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: Fix runtime error when rendering wireframe with empty geometry. #26465

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 19, 2023

Fixed #26464.

Description

Ensures no runtime error happens when trying to render the wireframe of a geometry with no vertex data definition.

@Mugen87 Mugen87 added this to the r155 milestone Jul 19, 2023
@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
645.2 kB (159.9 kB) 645.2 kB (159.9 kB) +45 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
438.3 kB (106 kB) 438.4 kB (106 kB) +45 B

@Mugen87 Mugen87 merged commit 39305cf into mrdoob:dev Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when empty BufferGeometry is rendered with wireframe
1 participant