Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated setting of focal length in examples #26460

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Jul 19, 2023

Related issue: N/A

Description

PerspectiveCamera no longer has a focalLength property and requires calling setFocalLength as of #8495. Setting the focal length changes the screenshot, so I just removed the call.

@Methuselah96 Methuselah96 changed the title Fix setting focal length in effects_anaglyphy example Fix setting focal length in examples Jul 19, 2023
@Methuselah96 Methuselah96 changed the title Fix setting focal length in examples Remove outdate setting of focal length in examples Jul 19, 2023
@Methuselah96 Methuselah96 changed the title Remove outdate setting of focal length in examples Remove outdated setting of focal length in examples Jul 19, 2023
@Mugen87 Mugen87 added this to the r155 milestone Jul 19, 2023
@Mugen87 Mugen87 merged commit ebbaecf into mrdoob:dev Jul 19, 2023
@Methuselah96 Methuselah96 deleted the fix-focal-length branch July 19, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants