WebGPURenderer: Support MSAA for texture render targets. #26451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sunag
reviewed
Jul 19, 2023
|
|
||
| } | ||
|
|
||
| const options = { sampleCount }; |
There was a problem hiding this comment.
I think we could use { samples } name to preserve the property name used in RenderTarget.
LeviPesin
reviewed
Aug 31, 2023
| @@ -156,6 +157,17 @@ class WebGPUTextureUtils { | |||
|
|
|||
| } | |||
|
|
|||
| if ( texture.isRenderTargetTexture && sampleCount > 1 ) { | |||
|
|
|||
| const msaaTextureDescriptorGPU = Object.assign( {}, textureDescriptorGPU ); | |||
There was a problem hiding this comment.
I think { ...textureDescriptorGPU } looks a bit clearer that it is just a clone.
LeviPesin
reviewed
Aug 31, 2023
| @@ -156,6 +157,17 @@ class WebGPUTextureUtils { | |||
|
|
|||
| } | |||
|
|
|||
| if ( texture.isRenderTargetTexture && sampleCount > 1 ) { | |||
There was a problem hiding this comment.
Here we can do just primarySampleCount > 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support antialiasing for texture render targets using the standard texture creation path to handle extra sampling texture creation required.