Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup wegl_gpgpu_water #26436

Merged
merged 1 commit into from
Jul 16, 2023
Merged

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Jul 15, 2023

Related issue: N/A

Description

The wegl_gpgpu_water assigns properties to ShaderMaterial that aren't actual properties of a ShaderMaterial. The more straightforward approach seems to assign those values directly to the uniforms.

@Mugen87 Mugen87 added this to the r155 milestone Jul 16, 2023
@Mugen87 Mugen87 merged commit dbb030b into mrdoob:dev Jul 16, 2023
@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 16, 2023

Sometimes it is required though to assign properties to a shader material so the renderer is able to generate GLSL defines. This is not true in this case so it's okay to clean things up.

@Methuselah96 Methuselah96 deleted the cleanup-webgl-gpgpu-water branch July 16, 2023 15:32
@Methuselah96
Copy link
Contributor Author

Good to know, any examples you can point to so I know what to look out for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants