Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CubeCamera: Remove tone mapping related code. #26435

Merged
merged 1 commit into from
Jul 15, 2023
Merged

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 15, 2023

Related issue: #26371

Description

Since the inline tone mapping only works when rendering to screen, the code in CubeCamera can be simplified.

@Mugen87 Mugen87 added this to the r155 milestone Jul 15, 2023
@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
643.9 kB (159.7 kB) 643.8 kB (159.6 kB) -48 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
437 kB (105.8 kB) 437 kB (105.8 kB) -48 B

@Mugen87 Mugen87 merged commit 6d1db4a into mrdoob:dev Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant