Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove setting Group.material in godrays example #26431

Merged
merged 2 commits into from
Jul 15, 2023
Merged

Remove setting Group.material in godrays example #26431

merged 2 commits into from
Jul 15, 2023

Conversation

Methuselah96
Copy link
Contributor

Related issue: N/A

Description

The object that is loaded is a Group which does not typically have a material property set. I could be missing something, but it seems like setting the material property is ineffectual.

@Mugen87 Mugen87 added this to the r155 milestone Jul 15, 2023
@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 15, 2023

I could be missing something, but it seems like setting the material property is ineffectual.

I guess the original dev wanted to apply the black MeshBasicMaterial to all objects in the scene although that is not necessary to achieve the intended visuals. Hence, I've simplified the scene a bit further.

@Mugen87 Mugen87 merged commit c5ad711 into mrdoob:dev Jul 15, 2023
@Methuselah96 Methuselah96 deleted the group-material branch July 15, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r155
Development

Successfully merging this pull request may close these issues.
2 participants
@Methuselah96 @Mugen87