Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeMaterial: unlit property #26429

Merged
merged 2 commits into from
Jul 14, 2023
Merged

NodeMaterial: unlit property #26429

merged 2 commits into from
Jul 14, 2023

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jul 14, 2023

Related issue: #26419, #26270

Description

Improve unlit support.

@sunag sunag added this to the r155 milestone Jul 14, 2023
@sunag sunag merged commit 6169e48 into mrdoob:dev Jul 14, 2023
@sunag sunag deleted the dev-unlit branch July 14, 2023 16:03
sunag added a commit to aardgoose/three.js that referenced this pull request Jul 14, 2023
* NodeMaterial: unlit property

* cleanup
sunag added a commit to aardgoose/three.js that referenced this pull request Jul 14, 2023
@@ -89,6 +90,12 @@ class NodeMaterial extends ShaderMaterial {

outputNode = this.constructOutput( builder, vec4( outgoingLightNode, diffuseColor.a ) );

// OUTPUT NODE

builder.stack.assign( output, outputNode );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So output is not defined in the case of unlit materials?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because if unlit is true so material.outputNode is equal output.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants