Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RenderTarget: Add count option for MRT. #26427

Merged
merged 10 commits into from
Feb 8, 2024
Merged

RenderTarget: Add count option for MRT. #26427

merged 10 commits into from
Feb 8, 2024

Conversation

CodyJasonBennett
Copy link
Contributor

@CodyJasonBennett CodyJasonBennett commented Jul 14, 2023 •
edited
Loading

Related issue: #21930

Description

Introduces a count parameter to RenderTarget options for MRT and deprecates WebGLMultipleRenderTargets.

Note: This PR aims to smoothen the 2D render target API, I haven't enhanced 3D and array cases as #22089 has done.

/cc @RenaudRohlinger

@github-actions
Copy link

github-actions bot commented Jul 14, 2023 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
676 kB (167.9 kB) 675.1 kB (167.9 kB) -906 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
456.6 kB (110.7 kB) 456.4 kB (110.7 kB) -235 B

@RenaudRohlinger
Copy link
Collaborator

Just reviewed it, looks good to me! Thanks for this Cody. Hopefully this time we can finally merge this one 👍

@Mugen87 Mugen87 added this to the r155 milestone Jul 17, 2023
@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 17, 2023 •
edited
Loading

@mrdoob Is removing WebGLMultipleRenderTargets and merging the functionality into WebGLRenderTarget okay with you? It is essentially a similar approach like when we have removed WebGLMultisampleRenderTarget (see #23455).

@CodyJasonBennett CodyJasonBennett changed the title WebGLRenderTarget: add count option for MRT RenderTarget: add count option for MRT Jul 25, 2023
@aardgoose aardgoose mentioned this pull request Jul 26, 2023
Merged
@mrdoob mrdoob modified the milestones: r155, r156 Jul 27, 2023
@Mugen87 Mugen87 modified the milestones: r156, r157 Aug 31, 2023
@mrdoob mrdoob modified the milestones: r157, r158 Sep 28, 2023
@mrdoob mrdoob modified the milestones: r158, r159 Oct 27, 2023
@mrdoob mrdoob modified the milestones: r159, r160 Nov 30, 2023
@mrdoob mrdoob modified the milestones: r160, r161 Dec 22, 2023
@mrdoob mrdoob modified the milestones: r161, r162 Jan 31, 2024
@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 8, 2024

Based on the general support of the PR and the positive signal of @mrdoob in #23444 (comment) let's merge the PR!

@Mugen87 Mugen87 merged commit 066664a into mrdoob:dev Feb 8, 2024
12 checks passed
@Mugen87 Mugen87 changed the title RenderTarget: add count option for MRT RenderTarget: Add count option for MRT. Feb 8, 2024
@Mugen87 Mugen87 mentioned this pull request Feb 8, 2024
Merged
@CodyJasonBennett CodyJasonBennett deleted the rt-mrt-default branch February 8, 2024 14:35
This was referenced Feb 17, 2024
Closed
Merged
@Mugen87 Mugen87 mentioned this pull request Feb 27, 2024
Closed
@Mugen87 Mugen87 mentioned this pull request Dec 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r162
Development

Successfully merging this pull request may close these issues.
4 participants
@CodyJasonBennett @RenaudRohlinger @Mugen87 @mrdoob