Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GUI title parameter in webgl_postprocessing_afterimage #26421

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

Methuselah96
Copy link
Contributor

Related issue: N/A

Description

Replaces the name parameter with title, since name is not a valid parameter for GUI. Presumably this was missed when switching from dat.gui to lil-gui.

@Methuselah96 Methuselah96 changed the title Fix GUI title in webgl_postprocessing_afterimage Fix GUI title parameter in webgl_postprocessing_afterimage Jul 14, 2023
@Mugen87 Mugen87 added this to the r155 milestone Jul 14, 2023
@Mugen87 Mugen87 merged commit bc5ac6c into mrdoob:dev Jul 14, 2023
@Methuselah96 Methuselah96 deleted the gui-title branch July 14, 2023 14:40
Methuselah96 added a commit to Methuselah96/three.js that referenced this pull request Oct 25, 2023
See mrdoob#26421 for explanation.
@Methuselah96 Methuselah96 mentioned this pull request Oct 25, 2023
Mugen87 pushed a commit that referenced this pull request Oct 25, 2023
* Cleanup examples

See #26421 for explanation.

* Update webgl_morphtargets_face.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants