Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples: tonemapping add backgroundIntensity gui #26411

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

vis-prime
Copy link
Contributor

Description

Since tonemapping example already has scene.backgroundBlurriness , adding scene.backgroundIntensity slider also

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 11, 2023

https://rawcdn.githack.com/vis-prime/three.js/tonemapping_example_gui_update/examples/webgl_tonemapping.html

@Mugen87 Mugen87 added this to the r155 milestone Jul 11, 2023
@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 11, 2023

Maybe we should make two folders "tone mapping" and "background". The tone mapping type and exposure are placed in the first folder, blurriness and intensity in the second one. That should make the GUI more clear.

Folders are done like so:

https://github.com/mrdoob/three.js/blob/edefdc237b2528b9668fb873a1c06cb835840303/examples/webgl_postprocessing_unreal_bloom.html#L127C16-L127C22

@vis-prime
Copy link
Contributor Author

vis-prime commented Jul 11, 2023

sure !, was thinking the same

will add it as
toneMapping and exposure under a tone mapping folder
&
blurriness and intensity under a background folder

some extra logic was there to remove exposure slider when tonemapping is null, just passing the tonemappingFolder to that function

@vis-prime vis-prime marked this pull request as ready for review July 11, 2023 19:27
@vis-prime
Copy link
Contributor Author

ummm... why isn't the rawcdn.githack not showing the updated version ?

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 11, 2023

It usually takes a while until the link refers to the latest commit. In the meanwhile, you can test the changes by using the commit hash in the URL: https://rawcdn.githack.com/vis-prime/three.js/8568419d2e9858c7e4e113a1366c641804bc1f11/examples/webgl_tonemapping.html

@Mugen87 Mugen87 merged commit 3d78962 into mrdoob:dev Jul 11, 2023
@vis-prime vis-prime deleted the tonemapping_example_gui_update branch July 12, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants